Edit - Software Engineering Stack Exchange

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

Required fields*

Rev

There definitely are uses for switch blocks, and if you are using one in a factory to decide a class you've already made other serious mistakes. I also find your 2nd to last statement about state machines and discounting switch statements to be rather unexpected.

whatsisname
– whatsisname

2017-08-08 20:31:21 +00:00
Commented Aug 8, 2017 at 20:31
@whatisname If you receive events from an enum based source (e.g. raw win32 messages) then you basically have to have a switch somewhere. It that example, it tends to be part of the platform library, but it is still there

Caleth
– Caleth

2017-08-09 07:45:37 +00:00
Commented Aug 9, 2017 at 7:45
@whatsisname Based on my own experience: whenever you have multiple switches for the same thing to do different things - then you are looking at a state machine in disguise. Then you step back and implement that state machine and your switch statements vanish.

GhostCat
– GhostCat

2017-08-09 07:46:01 +00:00
Commented Aug 9, 2017 at 7:46
Switch blocks are sooooo 1970. Use a table-mapping strategy. Map each value of an enum to a method or class, and execute from there. Throw an exception if you don't have one mapping defined.

Machado
– Machado

2017-08-09 12:44:49 +00:00
Commented Aug 9, 2017 at 12:44
@Machado And I would say: why build this mapping manually? That is where polymorphism kicks in ...

GhostCat
– GhostCat

2017-08-09 12:45:53 +00:00
Commented Aug 9, 2017 at 12:45

| Show 8 more comments

Correct minor typos or mistakes
Clarify meaning without changing it
Add related resources or links
Always respect the author’s intent
Don’t use edits to reply to the author

create code fences with backticks ` or tildes ~
```
like so
```
add language identifier to highlight code
```python
def function(foo):
print(foo)
```
put returns between paragraphs
for linebreak add 2 spaces at end
_italic_ or **bold**
indent code by 4 spaces
backtick escapes `like _so_`
quote by placing > at start of line
to make links (use https whenever possible)

<https://example.com>

[example](https://example.com)

<a href="https://example.com">example</a>

formatting help »
answering help »