Skip to main content
7 events
when toggle format what by license comment
Jul 5, 2017 at 3:01 comment added Samuel Note that git-flow doesn't even address pull requests and code reviews. It would look exactly the same from a commit history perspective whether you branch off release and merge to release with a fast-forward merge or if you made the commit directly in the release branch.
Jul 5, 2017 at 3:01 vote accept Mark Rogers
Jul 5, 2017 at 3:01 comment added Mark Rogers Ah ok, just standard branches and pull requests, there's no 'git-flow' naming style or anything.
Jul 5, 2017 at 2:56 comment added Samuel "there isn't a way to do pull requests from a fix branch to the release branch" how so? Git lets you merge any branch into any branch, and most Git PR systems have the ability to choose which branch to merge into when creating a PR. "How do you handle pull request review when fixing the release branch?" the same way that you described in your question. create a branch off release, and pr back into release branch. But AFAIK this isn't pure git-flow process. "pull request branching and review skipped if one is following pure git-flow?" yes that's my interpretation of pure git-flow.
Jul 5, 2017 at 2:36 comment added Mark Rogers Thanks for the response. This is how I read git-flow too, but the problem with this approach is that there isn't a way to do pull requests from a fix branch to the release branch. How do you handle pull request review when fixing the release branch? or is pull request branching and review skipped if one is following pure git-flow?
Jul 5, 2017 at 0:46 history edited Samuel CC BY-SA 3.0
added 345 characters in body
Jul 5, 2017 at 0:38 history answered Samuel CC BY-SA 3.0