Format code

Source Link

edit approved Jun 18, 2018 at 12:02

105
3

Is building the config in the constructor the best place so the work is implicit:

protected override void OnStart(string[] args) { // The first call for an instance, so the object is created & data is loaded ConfigSingleton MyConfig = ConfigSingleton.GetInstance;

 protected override void OnStart(string[] args)
 {
     // The first call for an instance, so the object is created & data is loaded
     ConfigSingleton MyConfig = ConfigSingleton.GetInstance;

     // Create object that checks db for data to process; relies on config
     Poller = new Poller(); 
     Poller.Start();
 }

}

    protected override void OnStart(string[] args)
    {
        ConfigSingleton MyConfig = ConfigSingleton.GetInstance;
        MyConfig.getConfig(); // Explicit call to get config from db

        // Create object that checks db for data to process; relies on config
        Poller = new Poller(); 
        Poller.Start();
    }

Should the work to check for the config tables be done by a separate, presumably static, class:

protected override void OnStart(string[] args) { if (!DBChecker.isTableReady()) { DBChecker.BuildTables(); }

 protected override void OnStart(string[] args)
 {
     if (!DBChecker.isTableReady())
     {
         DBChecker.BuildTables();
     }

     ConfigSingleton MyConfig = ConfigSingleton.GetInstance;
     MyConfig.getConfig();

     // Create object that checks db for data to process; relies on config
     Poller = new Poller(); 
     Poller.Start();
 }

}

        // Inside this function, a call is made to BusinessLayer.GetList1()
        MyController = new Controller(FirstParam); 
        MyController.Start();
        
        // Yet here, a similar version is called first and then the result is passed as a parameter
        List<Objects> MyList2 = BusinessLayer.GetList2();
        MySender = new Sender(SecondParam, MyList2);
        MySender.Start();

Is building the config in the constructor the best place so the work is implicit:

 protected override void OnStart(string[] args)
 {
     // The first call for an instance, so the object is created & data is loaded
     ConfigSingleton MyConfig = ConfigSingleton.GetInstance;

     // Create object that checks db for data to process; relies on config
     Poller = new Poller(); 
     Poller.Start();
 }

    protected override void OnStart(string[] args)
    {
        ConfigSingleton MyConfig = ConfigSingleton.GetInstance;
        MyConfig.getConfig(); // Explicit call to get config from db

        // Create object that checks db for data to process; relies on config
        Poller = new Poller(); 
        Poller.Start();
    }

Should the work to check for the config tables be done by a separate, presumably static, class:

 protected override void OnStart(string[] args)
 {
     if (!DBChecker.isTableReady())
     {
         DBChecker.BuildTables();
     }

     ConfigSingleton MyConfig = ConfigSingleton.GetInstance;
     MyConfig.getConfig();

     // Create object that checks db for data to process; relies on config
     Poller = new Poller(); 
     Poller.Start();
 }

        // Inside this function, a call is made to BusinessLayer.GetList1()
        MyController = new Controller(FirstParam); 
        MyController.Start();
        
        // Yet here, a similar version is called first and then the result is passed as a parameter
        List<Objects> MyList2 = BusinessLayer.GetList2();
        MySender = new Sender(SecondParam, MyList2);
        MySender.Start();

Is building the config in the constructor the best place so the work is implicit:

protected override void OnStart(string[] args) { // The first call for an instance, so the object is created & data is loaded ConfigSingleton MyConfig = ConfigSingleton.GetInstance;
```
 // Create object that checks db for data to process; relies on config
 Poller = new Poller(); 
 Poller.Start();
```
}

protected override void OnStart(string[] args)
{
    ConfigSingleton MyConfig = ConfigSingleton.GetInstance;
    MyConfig.getConfig(); // Explicit call to get config from db

    // Create object that checks db for data to process; relies on config
    Poller = new Poller(); 
    Poller.Start();
}

Should the work to check for the config tables be done by a separate, presumably static, class:

protected override void OnStart(string[] args) { if (!DBChecker.isTableReady()) { DBChecker.BuildTables(); }
```
 ConfigSingleton MyConfig = ConfigSingleton.GetInstance;
 MyConfig.getConfig();

 // Create object that checks db for data to process; relies on config
 Poller = new Poller(); 
 Poller.Start();
```
}

// Inside this function, a call is made to BusinessLayer.GetList1()
MyController = new Controller(FirstParam); 
MyController.Start();

// Yet here, a similar version is called first and then the result is passed as a parameter
List<Objects> MyList2 = BusinessLayer.GetList2();
MySender = new Sender(SecondParam, MyList2);
MySender.Start();

clarified question

Source Link

edited Apr 22, 2015 at 16:20

Joseph

393
4
7

A somewhat unrelated example that helps clarify the spirit of my question comes from a previous version of the solution (which I've paraphrased):

        // Inside this function, a call is made to BusinessLayer.GetList1()
        MyController = new Controller(FirstParam); 
        MyController.Start();
        
        // Yet here, a similar version is called first and then the result is passed as a parameter
        List<Objects> MyList2 = BusinessLayer.GetList2();
        MySender = new Sender(SecondParam, MyList2);
        MySender.Start();

Are there basic rules of thumb that govern when work should be done inside some other work, or outside, passed as parameter, etc, other than the obvious fact that it should at least be consistent?

A somewhat unrelated example that helps clarify the spirit of my question comes from a previous version of the solution (which I've paraphrased):

        // Inside this function, a call is made to BusinessLayer.GetList1()
        MyController = new Controller(FirstParam); 
        MyController.Start();
        
        // Yet here, a similar version is called first and then the result is passed as a parameter
        List<Objects> MyList2 = BusinessLayer.GetList2();
        MySender = new Sender(SecondParam, MyList2);
        MySender.Start();

Are there basic rules of thumb that govern when work should be done inside some other work, or outside, passed as parameter, etc, other than the obvious fact that it should at least be consistent?

Source Link

asked Apr 22, 2015 at 16:12

Joseph

393
4
7

How/when to "build" a Singleton that stores configuration data

I am a junior developer (think "intern-level" experience) working at a small shop more or less alone on a project that consumes data from a database, processes it, and inserts the results into another database. The solution is a Windows service written in C#.

A previous version of the solution used App.config for things like connection strings, time intervals for checking the db for new data, etc. The project manager wants for this information to be stored in a table in the db, and then have a singleton keep that data rather than needing to access the config file. The configuration data needs to be loaded at startup.

My current implementation has the singleton's constructor make a single call to getConfig(), a method that encapsulates the work of getting all the data from the db. We are now in the process of writing code that will check the db at startup to make sure those configuration tables are there and will build them if they aren't.

I have several uncertainties about the design:

Is building the config in the constructor the best place so the work is implicit:

 protected override void OnStart(string[] args)
 {
     // The first call for an instance, so the object is created & data is loaded
     ConfigSingleton MyConfig = ConfigSingleton.GetInstance;

     // Create object that checks db for data to process; relies on config
     Poller = new Poller(); 
     Poller.Start();
 }

or should I make an explicit public call to getConfig() during startup for the sake of clarity:

    protected override void OnStart(string[] args)
    {
        ConfigSingleton MyConfig = ConfigSingleton.GetInstance;
        MyConfig.getConfig(); // Explicit call to get config from db

        // Create object that checks db for data to process; relies on config
        Poller = new Poller(); 
        Poller.Start();
    }

Should the work to check for the config tables be done by a separate, presumably static, class:

 protected override void OnStart(string[] args)
 {
     if (!DBChecker.isTableReady())
     {
         DBChecker.BuildTables();
     }

     ConfigSingleton MyConfig = ConfigSingleton.GetInstance;
     MyConfig.getConfig();

     // Create object that checks db for data to process; relies on config
     Poller = new Poller(); 
     Poller.Start();
 }

or should it be handled internally by the configuration singleton, so the code would look like one of the variations above?

c#object-oriented-design

Stack Exchange Network

Return to Question

How/when to "build" a Singleton that stores configuration data