Skip to main content
Software Engineering

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

Required fields*

4
  • Knowing about customers would certainly be a SRP-violation. I would simply have the item receive the customer-no and quantity as a parameter for its getPrice-method, which the item would simply pass through to the PriceStrategy it was constructed with - no need for the item to have any inappropriate knowledge. But because all this info I want is info about the item - I would still ask the item. If I use provider-services - can I avoid constructor over-injection for objects which need data from different providers for the same business entity? Facades? Commented Mar 23, 2015 at 15:58
  • Constructor over-injection is essentially dependency over-injection, and it tells you that you have too many dependencies, which in turn means that you are over-violating the SRP. Injecting the dependencies via another mechanism will not fix this. I think you need to reduce the dependencies themselves. Commented Mar 23, 2015 at 16:09
  • To use a concrete example - at some point I will need to display items. For this, I need their no, name, price for current customer, availability, main-image-thumbnail and canonical URL (at least). A class which displays such itemlists cannot do without these dependencies, and thus needs to get the data either from the item itself or from the item plus a set of providers - or am I missing something fundamental? Commented Mar 23, 2015 at 16:18
  • Right, there will need to be such a class, which will still, though, have a single responsibility: to create a data set for a list control, by aggregating information provided from other classes, whose responsibilities are to contain and/or calculate that information. Commented Mar 23, 2015 at 16:40