Skip to main content

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

Required fields*

10
  • Seriously? By this logic, you will have to rewrite the code every time someone comes up with a new input. Commented Nov 25, 2010 at 16:04
  • 6
    @Robert, at SOME point adding a new case will not result in the simplest possible code anymore, at which point you write a new implementation. As you have the tests in place already, you know exactly when your new implementation does the same as the old one. Commented Nov 25, 2010 at 16:09
  • 1
    @Thorbjørn Ravn Andersen, exactly, the most important part of Red-Green-Refactor, is the refactoring. Commented Nov 25, 2010 at 16:17
  • +1: This is the general idea from my knowledge as well, but something needs to be said about fulfilling the implied contract (ie. the method name factorial). If you only ever spec (ie test) f(6) = 120 then you only ever need to 'return 120'. Once you start adding tests to ensure that f(x) == x*x-1...*x-x-1 : upperBound >= x >= 0 then you will arrive at a function that satisfies the factorial equation. Commented Nov 25, 2010 at 16:21
  • 1
    @SnOrfus, the place for "implied contracts" to be is in the test cases. If you contract is for factorials, you TEST if known factorials are and if known non-factorials aren't. Plenty of them. Doesn't take long to convert the list of the ten first factorials to a for-loop testing every number up to the tenth factorial. Commented Nov 25, 2010 at 16:31