Skip to main content
Code Review

Return to Question

Tweeted twitter.com/StackCodeReview/status/1177598942361653252
edited title
Link
Mast Mod
Mast Mod
  • 13.8k
  • 2
  • 37
  • 89

Reviewing Programming Challenge Requirementsrequirements and Givensgivens

added 7 characters in body
Source Link
dfhwze
dfhwze
  • 14.2k
  • 7
  • 15

As I came across this answer Codility's Permutation Check in C# [answer #200620], I noticed the user reviewed quite a few requirements of the challenge, before reviewing the OP's code. My questions concern general on-topicness of such reviews. This answer isserves as a mere example.

Questions:

  • Is it on-topic to review a challenge's requirements, given the OP's code also gets reviewed?
  • Should a review confront the OP with the bad practices of the challenge; e.g. can we expect OP to change (to some extend) what is provided by the challenge?

As I came across this answer Codility's Permutation Check in C# [answer #200620], I noticed the user reviewed quite a few requirements of the challenge, before reviewing the OP's code. My questions concern general on-topicness of such reviews. This answer is a mere example.

Questions:

  • Is it on-topic to review a challenge's requirements, given the OP's code also gets reviewed?
  • Should a review confront the OP with the bad practices of the challenge; e.g. can we expect OP to change (to some extend) what is provided by the challenge?

As I came across this answer Codility's Permutation Check in C# [answer #200620], I noticed the user reviewed quite a few requirements of the challenge, before reviewing the OP's code. My questions concern general on-topicness of such reviews. This answer serves as a mere example.

Questions:

  • Is it on-topic to review a challenge's requirements, given the OP's code also gets reviewed?
  • Should a review confront the OP with the bad practices of the challenge; e.g. can we expect OP to change (to some extend) what is provided by the challenge?
Source Link
dfhwze
dfhwze
  • 14.2k
  • 7
  • 15

Reviewing Programming Challenge Requirements and Givens

As I came across this answer Codility's Permutation Check in C# [answer #200620], I noticed the user reviewed quite a few requirements of the challenge, before reviewing the OP's code. My questions concern general on-topicness of such reviews. This answer is a mere example.

Questions:

  • Is it on-topic to review a challenge's requirements, given the OP's code also gets reviewed?
  • Should a review confront the OP with the bad practices of the challenge; e.g. can we expect OP to change (to some extend) what is provided by the challenge?