Timeline for Asking about code in a pull request to my code base
Current License: CC BY-SA 3.0
13 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Oct 2, 2017 at 14:03 | history | edited | Mathieu GuindonMod | CC BY-SA 3.0 |
added 727 characters in body
|
| Sep 21, 2017 at 1:57 | history | edited | Mathieu GuindonMod | CC BY-SA 3.0 |
added 44 characters in body
|
| Sep 20, 2017 at 20:04 | vote | accept | Conor Mancone | ||
| Sep 20, 2017 at 19:34 | history | edited | Mathieu GuindonMod | CC BY-SA 3.0 |
added 15 characters in body
|
| Sep 20, 2017 at 19:32 | comment | added | Simon Forsberg Mod | @Mat'sMug Okay, yes, the fact that it is not merged is indeed the deal-breaker. I agree with you, but I think you should edit your answer to make it clearer that if the PR would be merged, then it would be on-topic. | |
| Sep 20, 2017 at 18:46 | comment | added | Conor Mancone | Well everyone agrees that it is off topic, so that's something :) I think a big part of why I wanted to do this is to see how others assess the same bit of code. Again, it isn't an attempt to pick at the person (or their code), but I'm newer to hiring than to code, and a big part of hiring is assessing how well other people write code. It's one thing to say "This is bad code" but it is another thing to say "This is bad code and a person applying for X job should know better". Seeing how other people view the code was one idea I had on how to start calibrating that sense better for myself. | |
| Sep 20, 2017 at 18:42 | history | edited | Mathieu GuindonMod | CC BY-SA 3.0 |
emphasis
|
| Sep 20, 2017 at 18:28 | comment | added | Mathieu Guindon Mod | @SimonForsberg the OP doesn't maintain the code that's in the PR - yet. It's not merged, it's not in his repository, it's not his work, and he might not even have write access to that fork. I'm 100% sure we've closed questions on these grounds before, and will continue to do so in the future. I firmly disagree with it being ok to take someone's work and put it up for review on this site - it boils down to "hey folks look at this mess of a PR I got, whadaya think?" | |
| Sep 20, 2017 at 18:24 | comment | added | Simon Forsberg Mod | I have to downvote this because your answer make it sound like it's off-topic (as indicated by the above comments as well). I don't think it is off-topic. The OP of this meta question is the maintainer of the code. I would however recommend against posting it here and I would possibly downvote the question for being posted for the reasons stated here on meta ("I got this PR and I reviewed the code myself so I know it is not good code"), but I do think it is on-topic. | |
| Sep 20, 2017 at 17:58 | comment | added | Mathieu Guindon Mod | The spirit of the rule is that we want reviewees to post their code. Take the latest rubberduck question for example: I own the repository and maintain the project, but the person working on a refactoring feature is putting their code up for review here well before they submit the PR. As the owner of Rubberduck, that code currently belongs to their fork, not mine; it's their work, not mine. If they want to post it here, it's their decision. After it's merged though, then it's part of my code base, and I'm the one that now has to maintain it. Subtly different, but important IMO. | |
| Sep 20, 2017 at 17:51 | comment | added | Conor Mancone | Although now you've made me curious: it was my understanding that code is on topic if it is your code or code you maintain: from that perspective, I would have expected something like this to be generally on-topic. Am I confused? | |
| Sep 20, 2017 at 17:49 | comment | added | Conor Mancone | Thanks for the feedback. Obviously, that makes a lot of sense: I had my own doubts, which is why I posted this here first. I have to be clear about one part though: it certainly isn't my goal to pick on the person in question. Rather, it's always good to double check my own thought processes. I'm confident in my conclusions so I don't think the overall answer is going to change (i.e. this code is no good), but I always appreciate a second pair of eyes: sometimes you learn stuff anyway, even when you've done it a hundred times. | |
| Sep 20, 2017 at 17:35 | history | answered | Mathieu GuindonMod | CC BY-SA 3.0 |