Timeline for Reviewing "design"
Current License: CC BY-SA 4.0
17 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Nov 12, 2022 at 14:33 | history | edited | Toby Speight | CC BY-SA 4.0 |
Spelling and grammar; slight wording change
|
| Jun 10, 2020 at 13:09 | history | edited | CommunityBot |
Commonmark migration
|
|
| Aug 20, 2014 at 1:57 | comment | added | RubberDuck | I'm with Simon on most of this. Saying you're unsure if you did the right thing is not the same as saying you did something bad. It's just saying you're unsure. Also, changing the design does not always mean a radical change to the implementation. we discussed this question a good bit today. It's a good example of a case where changing how the user interacts with the code barely changes it's implementation. | |
| Aug 19, 2014 at 17:23 | history | edited | rolflMod | CC BY-SA 3.0 |
clarify last point.
|
| Aug 19, 2014 at 17:11 | comment | added | Simon Forsberg | The last two points in the conclusion seems a bit contradictory to me. | |
| Aug 19, 2014 at 16:34 | comment | added | rolfl Mod | Added 'AppDesign.se' section. | |
| Aug 19, 2014 at 16:33 | history | edited | rolflMod | CC BY-SA 3.0 |
Added AppDesign
|
| Aug 19, 2014 at 15:51 | comment | added | Simon Forsberg | Also, there's nothing indicating that the asker is aware that the design is bad. "I don't know the design is good, can the design be improved?" | |
| Aug 19, 2014 at 15:49 | comment | added | Simon Forsberg | Design Only Question (DOQ) - Agreed. Implementation Only Question (IOQ) - Agreed. Design First Question (DFQ) - Do not agree. I don't see how you would answer that differently from the IOQ. In the IOQ you manage to somehow review the design while reviewing the code. Why should that not be possible in the DFQ? | |
| Aug 19, 2014 at 14:30 | history | edited | rolflMod | CC BY-SA 3.0 |
change summary to 'using examples'.
|
| Aug 19, 2014 at 14:23 | history | edited | rolflMod | CC BY-SA 3.0 |
edited body
|
| Aug 19, 2014 at 14:16 | comment | added | rolfl Mod | @SimonAndréForsberg - added Summary and Conclusion sections. | |
| Aug 19, 2014 at 14:16 | history | edited | rolflMod | CC BY-SA 3.0 |
Added Summary and Conclusion sections.
|
| Aug 19, 2014 at 9:41 | comment | added | Simon Forsberg | Let's say that I primarily want the design of my (implemented) code to be reviewed, if I don't ask about it then answers can comment about it, but if I do ask about it then my question is off-topic? That seems completely illogical. | |
| Aug 19, 2014 at 9:40 | comment | added | Simon Forsberg | -1 primarily because: a) Your answer is not entirely clear to me, 80% is spent about off-topic while 20% about on-topic. Remember that on Code Review, even if you ask about one thing answers can be about completely different things. b) design reviews are only on-topic when the question does not ask for one sounds like a silly idea to me, how can anything be on-topic when you don't ask for it? It will be like an elephant in the room. | |
| Aug 19, 2014 at 7:13 | comment | added | Pimgd | +1 for design reviews are only on-topic when the question does not ask for one!. I had the idea that "if you can comment about it then it should be on-topic to ask for it too" but that seems to be wrong and I thank you for correcting me. | |
| Aug 18, 2014 at 18:11 | history | answered | rolflMod | CC BY-SA 3.0 |