Skip to main content
Code Review

Return to Answer

replaced http://meta.codereview.stackexchange.com/ with https://codereview.meta.stackexchange.com/
Source Link
Community Bot
Community Bot
  • 5
replaced http://meta.codereview.stackexchange.com/ with https://codereview.meta.stackexchange.com/
Source Link
Community Bot
Community Bot
  • 5

I'd say try it.
If we end up not liking it, we'll update the rules.

I like the idea of reviewing a patch file, but reading through a diff file could be messy and as Mark Loeser pointed outMark Loeser pointed out, there may not be enough context to review the code adequately.

The reason I like the idea of reviewing a diff, is we can see the original problem and your solution to the problem, and then we could review whether or not you provided an optimal solution.

I'd say try it.
If we end up not liking it, we'll update the rules.

I like the idea of reviewing a patch file, but reading through a diff file could be messy and as Mark Loeser pointed out, there may not be enough context to review the code adequately.

The reason I like the idea of reviewing a diff, is we can see the original problem and your solution to the problem, and then we could review whether or not you provided an optimal solution.

I'd say try it.
If we end up not liking it, we'll update the rules.

I like the idea of reviewing a patch file, but reading through a diff file could be messy and as Mark Loeser pointed out, there may not be enough context to review the code adequately.

The reason I like the idea of reviewing a diff, is we can see the original problem and your solution to the problem, and then we could review whether or not you provided an optimal solution.

Source Link
jliv902
jliv902
  • 2k
  • 10
  • 13

I'd say try it.
If we end up not liking it, we'll update the rules.

I like the idea of reviewing a patch file, but reading through a diff file could be messy and as Mark Loeser pointed out, there may not be enough context to review the code adequately.

The reason I like the idea of reviewing a diff, is we can see the original problem and your solution to the problem, and then we could review whether or not you provided an optimal solution.