Fix invalid role configuration (#251)

* Catch invalid role configuration

* Fix invalid role configuration

Author: NMertsch

prod-config.toml

@@ -16,7 +16,7 @@ pretix_cache_file = "pretix_cache.json"
 "Personal" = ["Participants", "Onsite Participants"]
 "Education" = ["Participants", "Onsite Participants"]
 "Community Contributors" = ["Participants", "Onsite Participants"]
-"Grant ticket" = ["PARTICIPANTS", "Onsite Participants"]
+"Grant ticket" = ["Participants", "Onsite Participants"]
 # remote participants
 "Remote Participation Ticket" = ["Participants", "Remote Participants"]
 "Remote Grant ticket" = ["Participants", "Remote Participants"]
@@ -27,7 +27,7 @@ pretix_cache_file = "pretix_cache.json"
 "Presenter" = ["Participants", "Onsite Participants", "Speakers"]
 
 [registration.variation_to_roles]
-"Volunteer" = ["Volunteers"]
+"Volunteer" = ["Volunteers", "Onsite Volunteers"]
 
 [program_notifications]
 # UTC offset in hours (e.g. 2 for CEST)

src/europython_discord/registration/cog.py

@@ -93,6 +93,12 @@ async def on_submit(self, interaction: discord.Interaction) -> None:
         await interaction.user.edit(nick=nickname)
 
         roles = [discord_get(interaction.guild.roles, name=role_name) for role_name in role_names]
+        if any(role is None for role in roles):
+            await self.log_error_to_user(interaction, "Internal error, please contact us.")
+            await self.log_error_to_channel(interaction, f"Found invalid role in {role_names}")
+            _logger.error("At least one of the role names %s is invalid", role_names)
+            return
+
         _logger.info("Assigning %r role_names=%r", name, role_names)
         await interaction.user.add_roles(*roles)
 

test-config.toml

@@ -16,7 +16,7 @@ pretix_cache_file = "pretix_cache.json"
 "Personal" = ["Participants", "Onsite Participants"]
 "Education" = ["Participants", "Onsite Participants"]
 "Community Contributors" = ["Participants", "Onsite Participants"]
-"Grant ticket" = ["PARTICIPANTS", "Onsite Participants"]
+"Grant ticket" = ["Participants", "Onsite Participants"]
 # remote participants
 "Remote Participation Ticket" = ["Participants", "Remote Participants"]
 "Remote Grant ticket" = ["Participants", "Remote Participants"]
@@ -27,7 +27,7 @@ pretix_cache_file = "pretix_cache.json"
 "Presenter" = ["Participants", "Onsite Participants", "Speakers"]
 
 [registration.variation_to_roles]
-"Volunteer" = ["Volunteers"]
+"Volunteer" = ["Volunteers", "Onsite Volunteers"]
 
 [program_notifications]
 # UTC offset in hours (e.g. 2 for CEST)