Selection sort algorithm in Rust

Question

I am just trying to use Rust so I will be thankful for all remarks and corrections:

fn selection_sort(array: &mut [i32]) {

    let mut min;

    for i in 0..array.len() {

        min = i;

        for j in (i+1)..array.len() {

            if array[j] < array[min] {
                min = j;
            }
        }

        let tmp = array[i];
        array[i] = array[min];
        array[min] = tmp;
    }
}

fn main() {

    let mut values = [ 5, 8, 4, 1, 7, 2, 3, 6 ];
    println!("Hello, world! The value is {:?}", values);

    selection_sort(&mut values);
    println!("Hello, world! The value is {:?}", values);
}

MAG · Accepted Answer · 2016-03-14 09:22:36Z

8

You could use min_by_key to find the minimum's index and the method swap defined in slices:

fn selection_sort(array: &mut [i32]) {
    let len = array.len();
    for i in 0..len {
        let min = (i..len).min_by_key(|x| array[*x])
                          .unwrap();
        array.swap(min, i);
    }
}

edited Mar 14, 2016 at 9:22

answered Mar 14, 2016 at 9:07

MAG

2,97415 silver badges30 bronze badges

Add a comment |

Shepmaster · Accepted Answer · 2016-03-14 13:51:49Z

No newlines after an opening brace but before the code starts
Use spaces around binary operators like +.
Use swap. This prevents you from needing to make a copy/clone of the variable.
Declare variables in as small a scope as possible. There's no reason to declare min outside of the array.
I'd use more iterator methods like enumerate to avoid array indexing, which incurs a small penalty for out-of-bounds checking.

fn selection_sort(array: &mut [i32]) {
    for i in 0..array.len() {
        let min_idx = array[i..].iter()
            .enumerate()
            .min_by_key(|&(_, v)| v)
            .map(|(i, _)| i)
            .unwrap_or(0);

        array.swap(i, min_idx + i);
    }
}

As a follow-up, I'd challenge you to make this algorithm work with more than just i32 types!

Stack Exchange Network

Selection sort algorithm in Rust

2 Answers 2

You must log in to answer this question.

Hot Network Questions

Selection sort algorithm in Rust

2 Answers 2

You must log in to answer this question.

Related

Hot Network Questions