Timeline for Using std::unique_ptr and std::move
Current License: CC BY-SA 4.0
19 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Dec 21, 2024 at 12:17 | history | edited | Billal BEGUERADJ | CC BY-SA 4.0 |
added 4 characters in body
|
| Nov 23, 2014 at 6:43 | history | edited | 200_success |
edited tags
|
|
| Nov 23, 2014 at 1:29 | answer | added | Goswin von Brederlow | timeline score: 0 | |
| Nov 23, 2014 at 1:05 | history | rollback | Jamal |
Rollback to Revision 5
|
|
| Nov 23, 2014 at 0:58 | history | edited | Goswin von Brederlow | CC BY-SA 3.0 |
Add revised code example
|
| Nov 23, 2014 at 0:03 | history | tweeted | twitter.com/#!/StackCodeReview/status/536309058354290688 | ||
| Nov 22, 2014 at 23:25 | history | edited | Goswin von Brederlow | CC BY-SA 3.0 |
add dummy implementation for Fan so you can test stuff
|
| Nov 22, 2014 at 20:56 | answer | added | davidhigh | timeline score: 2 | |
| Nov 22, 2014 at 20:56 | answer | added | nwp | timeline score: 5 | |
| Nov 22, 2014 at 20:55 | answer | added | dyp | timeline score: 11 | |
| Nov 22, 2014 at 19:35 | history | edited | Goswin von Brederlow | CC BY-SA 3.0 |
get into ==> go into
|
| Nov 22, 2014 at 19:17 | comment | added | Goswin von Brederlow |
I'm unsure about having to use std::move() twice. But that is required if Inproc() takes std::unique_ptr<Fan> or std::unique_ptr<Fan>&&. On the other hand if Inproc() takes std::unique_ptr<Fan>& then the std::move in create becomes uneccessary. Is that a more common style?
|
|
| Nov 22, 2014 at 19:14 | comment | added | Goswin von Brederlow | @nwp: Fan does fair queueing of incoming messages and round-robin on outgoing messages and Inproc connects 2 fans for in process communication (as opposed to network). | |
| Nov 22, 2014 at 18:53 | comment | added | nwp |
The code is correct as far as move semantics go. I would like you to say what Inproc and Fan are actually supposed to do before reviewing.
|
|
| Nov 22, 2014 at 18:20 | history | edited | Jamal | CC BY-SA 3.0 |
added 6 characters in body; edited title
|
| Nov 22, 2014 at 18:19 | history | edited | Goswin von Brederlow | CC BY-SA 3.0 |
deleted 8 characters in body
|
| Nov 22, 2014 at 18:18 | comment | added | Goswin von Brederlow | Would it be possible to have Inproc(Fan &&bound__, Fan &&connected__); as constructor and still use std::unique_ptr and std::move? | |
| Nov 22, 2014 at 17:44 | review | First posts | |||
| Nov 22, 2014 at 20:06 | |||||
| Nov 22, 2014 at 17:43 | history | asked | Goswin von Brederlow | CC BY-SA 3.0 |