Timeline for MS Access VBA code to compare records in a table and combine data where necessary
Current License: CC BY-SA 3.0
5 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Jun 9, 2014 at 14:46 | vote | accept | WhatEvil | ||
| Jun 9, 2014 at 14:42 | comment | added | WhatEvil | I've revised this code. Please see: codereview.stackexchange.com/questions/53793/… | |
| Jun 9, 2014 at 12:33 | comment | added | RubberDuck |
Not when you're duplicating code. Anytime your fingers reach for cntl + c, you should stop and rethink. What if suddenly your logic needs to change? Now you need to find every instance of that logic in your code. Chances are, you'll miss one. Now you have a bug. Granted, markCommentIfEmpty might not be the best name I've ever come up with.
|
|
| Jun 9, 2014 at 12:15 | comment | added | WhatEvil |
Re: Adding a function (markCommentIfEmpty) isn't there something to be said for code readability? If Not Right(strCOMMENT2, 1) = "~" Then is immediately obvious, whereas strComment1 = markCommentIfEmpty(strComment1) means you have to look for the function to understand what it does.
|
|
| Jun 5, 2014 at 20:31 | history | answered | RubberDuck | CC BY-SA 3.0 |