Timeline for CodeIgniter Model I built
Current License: CC BY-SA 3.0
12 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Jun 10, 2020 at 13:24 | history | edited | CommunityBot |
Commonmark migration
|
|
| Dec 27, 2016 at 15:02 | history | edited | Malachi | CC BY-SA 3.0 |
wording, formatting and deletion
|
| Mar 25, 2014 at 15:12 | vote | accept | Kevin | ||
| Mar 25, 2014 at 14:40 | comment | added | Malachi |
you need to be able to nest functions. some of those if statements are used in multiple places to return the same information inside of a function. turn those into functions as well, and then you can use that function inside of the bigger function, in other words encapsulation.
|
|
| Mar 25, 2014 at 14:36 | comment | added | Kevin |
@Malachi talking about the if then statements in the functions not sure what you mean about the paragraph under this.
|
|
| Mar 25, 2014 at 13:38 | history | edited | Malachi | CC BY-SA 3.0 |
added 508 characters in body
|
| Mar 25, 2014 at 12:35 | comment | added | Malachi | @o7thWebDesign, yes. I noticed that you use them over and over again. it kind of looks like you weren't sure how to structure the functions. like whether to put action stuff together or the components together. you can actually put the components together first, in a function, and then create the functions the way you have them with the other functions being called inside of them. it will make all of them look a lot cleaner, and probably reduce some of the code. | |
| Mar 25, 2014 at 12:01 | comment | added | Kevin | Why break them up into seperate functions? Because of the re-use of some of them? | |
| Mar 24, 2014 at 22:45 | comment | added | Malachi | you say arguably, do you mean that some would say it is bad where some would say it is good? or would everyone have mixed feelings? @amon | |
| Mar 24, 2014 at 22:43 | history | edited | Malachi | CC BY-SA 3.0 |
edited body
|
| Mar 24, 2014 at 22:25 | comment | added | amon |
not only is the first point arguably bad advice, you also switched two lines so that you return before you can set $this->msg.
|
|
| Mar 24, 2014 at 22:11 | history | answered | Malachi | CC BY-SA 3.0 |