Timeline for C++20 Performance Test Code Generator
Current License: CC BY-SA 4.0
8 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Nov 2, 2024 at 15:31 | comment | added | pacmaninbw♦ | If you have the time you might want to look at the follow up question | |
| Oct 18, 2024 at 16:35 | comment | added | pacmaninbw♦ | Just FYI, you missed 2 bugs in BasicGenericDictionaryTest.h. performanceExecution() was calling testIDtoNameLoop() twice and wasn't calling testIDtoNameLoop(). testIDtoNameLoop() had compilation errors. Both issues are fixed now. Still a very good review, and there are a couple of suggestions I'm still working on. | |
| Oct 15, 2024 at 14:35 | vote | accept | pacmaninbw♦ | ||
| Oct 14, 2024 at 0:42 | comment | added | pacmaninbw♦ | FYI, I tried to use std::format, but that is in g++-13 which is not supported on Ubuntu 22.04. | |
| Oct 4, 2024 at 14:42 | comment | added | pacmaninbw♦ | Minevalnum should be a constexpr. It is in a later version which hasn't been pushed to GitHub yet. | |
| Oct 4, 2024 at 14:08 | comment | added | pacmaninbw♦ | The one problem with putting anything in the test main.cpp is that the performance test cases will eventually be included in the unit testing in the parent directory which is not included in this question, it was in the previous question. | |
| Oct 4, 2024 at 14:01 | comment | added | pacmaninbw♦ |
Interesting, but a lot to take in. Thank you for the links to C++ Core Guidelines that is helpful. I started programming in C before there was C++ so there can definitely be problems there. If you look at my [first question on code review] (codereview.stackexchange.com/questions/121917/…) you will see that there was way too much C in my C++ code.
|
|
| Oct 4, 2024 at 0:37 | history | answered | indi | CC BY-SA 4.0 |