Timeline for Fizzbuzz in C sharp
Current License: CC BY-SA 4.0
9 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Mar 4, 2024 at 21:30 | comment | added | Davislor | @Peilonrayz I originally interpreted your answer as saying that this was a trick question, and I didn’t think it was. | |
| Mar 4, 2024 at 21:16 | comment | added | Peilonrayz♦ | "I think the code itself was no more or less SOLID." Thanks. | |
| Mar 4, 2024 at 21:10 | comment | added | Davislor | @Peilonrayz Since I wasn’t clear, then: I didn’t add or remove any helper functions, or change what their parameters or return values. So I think the code itself was no more or less SOLID. I included an example of what I might tell an interviewer to demonstrate how the code relates to SOLID. I do think of this refactoring as “cleaner” even simpler and easier to understand, than the original. Which wasn’t bad! | |
| Mar 4, 2024 at 15:44 | comment | added | Mauricio Gracia Gutierrez | I actually said to the interviewer that he could ask me anything regarding SOLID and CLEAN CODE but he refused - thanks for you very clear and empatic response here is my approach - codereview.stackexchange.com/a/290865/29384 | |
| Mar 4, 2024 at 2:40 | comment | added | Davislor | @Peilonrayz But also, if your honest opinion is that the principle isn’t applicable to this problem, you can demonstrate your understanding of the principle by explaining that. | |
| Mar 4, 2024 at 2:36 | comment | added | Davislor | @Peilonrayz I was thinking of, “The problem isn't really something you apply principles too. And shows if people overcomplicate problems.” If you in fact agree that the interviewer does want to see the candidate find a way to apply the principles, great! | |
| Mar 4, 2024 at 2:06 | comment | added | Peilonrayz♦ | "I’m expected to demonstrate some familiarity with both SOLID and Clean Code". I think we can both agree both our solutions have improved Clean Code over the OP's. Do you believe you have improved the SOLID of the function? I have read the final paragraph where you somewhat tie SOLID to the code, but unlike the Clean Code example I can't see where you've explained an improvement in SOLID. I'm happy and would like to be wrong, but I can't understand how I am. If your only contestation is "familiarity" then sure, let's agree I'm wrong. | |
| Mar 3, 2024 at 23:17 | history | edited | Davislor | CC BY-SA 4.0 |
added 68 characters in body
|
| Mar 3, 2024 at 23:11 | history | answered | Davislor | CC BY-SA 4.0 |