Timeline for Remove all text files with non-US-ASCII text encoding from current folder on Linux
Current License: CC BY-SA 4.0
3 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Feb 18, 2024 at 13:56 | comment | added | Peter Cordes |
@TobySpeight: I only noticed while looking at the asm to see if isascii() was a table lookup in glibc like isalpha() and others. (It's not). I was looking for 8-bit operations, and saw a cmp al, -1, then realized that was a broken EOF check.
|
|
| Feb 18, 2024 at 10:02 | comment | added | Toby Speight |
I can't believe I missed char current - especially after checking that the input to isascii() came from fgetc() and so didn't need converting via unsigned char! This is a great review.
|
|
| Feb 18, 2024 at 0:30 | history | answered | Peter Cordes | CC BY-SA 4.0 |