Timeline for Qt Number Generator v2

11 events

when toggle format	what		by	license	comment
Apr 15, 2019 at 14:45	comment	added	TrebledJ		@sliziky This is a good use case for enums (enumerated types). These are a tad safer than strings (the compiler will catch any typos) while maintaining readability. Hope this helps ~
Apr 15, 2019 at 11:57	comment	added	sliziky		Thank you for great review :) How would you solve passing into `( int low, int high, bool random )` if I added the option you mentioned `sequential-n` , so far I got `const QString& mode` and then `if (mode == "random" ) / if (mode == "sequential") / if (mode == "sequential-n")` which for me is more readable than passing int/char and compare with values . Although `#define random 1` could "solve" readability
Apr 14, 2019 at 18:33	vote	accept	sliziky
Apr 14, 2019 at 16:43	history	edited	TrebledJ	CC BY-SA 4.0	major haul
Apr 14, 2019 at 16:40	comment	added	TrebledJ		I realised I missed out a bunch of stuff on my first read. Had to read the code a third time to actually see a large proportion of the inherent problems. :P
Apr 14, 2019 at 16:38	history	edited	TrebledJ	CC BY-SA 4.0	major haul
Apr 14, 2019 at 16:34	comment	added	greybeard		Welcome to Code Review! Nice job, first post or not.
Apr 14, 2019 at 15:38	history	edited	TrebledJ	CC BY-SA 4.0	added 29 characters in body
Apr 14, 2019 at 15:27	history	edited	TrebledJ	CC BY-SA 4.0	added 29 characters in body
Apr 14, 2019 at 15:25	review	First posts
Apr 14, 2019 at 16:34
Apr 14, 2019 at 15:21	history	answered	TrebledJ	CC BY-SA 4.0