Timeline for A simple mastermind clone
Current License: CC BY-SA 4.0
11 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Sep 26, 2018 at 17:27 | history | edited | Eric Lippert | CC BY-SA 4.0 |
added 60 characters in body
|
| Aug 31, 2018 at 13:41 | comment | added | Rick Davin |
Excellent and thorough as always but I think you glossed over why Random should be at the class level and not local to a given method. As presented, it just looks as if it was just for cleaner organization.
|
|
| S Aug 31, 2018 at 12:46 | history | suggested | Anders Marzi Tornblad | CC BY-SA 4.0 |
Small change to an intermediate code section, correcting `GenRandom` to `random`
|
| Aug 31, 2018 at 12:30 | review | Suggested edits | |||
| S Aug 31, 2018 at 12:46 | |||||
| Aug 31, 2018 at 9:52 | comment | added | JAD |
Your function GenerateCode is missing a couple of +s
|
|
| Aug 31, 2018 at 7:43 | comment | added | Joshua Webb |
The call to your factored Plural method is passing turn instead of maximumTurns - 1 - turn, perhaps factoring that out into a remainingTurns variable first would be better e.g. remainingTurns = maximumTurns - 1 - turn; Console.WriteLine($"You have {remainingTurns} {Plural(remainingTurns, "turn")} left.");
|
|
| Aug 31, 2018 at 2:11 | comment | added | Steve | Listen to this man's advice. I would be honored if I got some code review like this from @ericlippert! Very thorough. | |
| Aug 31, 2018 at 0:52 | history | edited | Eric Lippert | CC BY-SA 4.0 |
edited body
|
| Aug 31, 2018 at 0:44 | history | edited | Eric Lippert | CC BY-SA 4.0 |
edited body
|
| Aug 31, 2018 at 0:31 | history | edited | Eric Lippert | CC BY-SA 4.0 |
added 523 characters in body
|
| Aug 31, 2018 at 0:24 | history | answered | Eric Lippert | CC BY-SA 4.0 |