Skip to main content
34 events
when toggle format what by license comment
Aug 26, 2019 at 21:32 history edited user125391 CC BY-SA 4.0
added 304 characters in body
Nov 6, 2018 at 19:35 vote accept CommunityBot
Aug 31, 2018 at 9:29 comment added Mast @JohnDoea Feel free to ask a new question with the improved, complete and working code.
Aug 31, 2018 at 9:24 comment added user125391 @Mast crap this is part of the original code but wasn't here for some reason... Anyway, the code doesn't work without this...
Aug 31, 2018 at 4:26 comment added Mast Please don't update the code after receiving answers, post a follow-up question instead. Please make sure you've fixed the earlier mentioned problems first.
Aug 31, 2018 at 4:22 history rollback Mast
Rollback to Revision 14
Aug 31, 2018 at 3:09 history edited user125391 CC BY-SA 4.0
added 42 characters in body
Aug 31, 2018 at 2:54 history edited user125391 CC BY-SA 4.0
added 43 characters in body
Aug 31, 2018 at 2:45 history edited user125391 CC BY-SA 4.0
deleted 43 characters in body
S Aug 30, 2018 at 17:42 history bounty ended CommunityBot
S Aug 30, 2018 at 17:42 history notice removed user125391
Aug 29, 2018 at 15:50 comment added user125391 @Mast I have yet to test the code seriously (Sam's answer seems promising and I need to understand the code better first). I haven't fixed that problem.
Aug 29, 2018 at 9:10 comment added Mast Does the code work as intended? As in, did you fix the problem presented earlier to your satisfaction?
Aug 28, 2018 at 22:11 comment added Sᴀᴍ Onᴇᴌᴀ Normally after receiving answers you are not allowed to change your code anymore. This is to ensure that answers do not get invalidated and have to hit a moving target. If you have changed your code you can either post it as an answer (if it would constitute a code review) or ask a new question with your changed code (linking back to this one as reference). Refer to this post for more information. I have updated my answer accordingly but please don't edit the code anymore.
Aug 28, 2018 at 21:00 history tweeted twitter.com/StackCodeReview/status/1034546166178959360
Aug 28, 2018 at 18:30 history edited user125391 CC BY-SA 4.0
added 31 characters in body
Aug 28, 2018 at 18:25 history edited Sᴀᴍ Onᴇᴌᴀ CC BY-SA 4.0
update wording
Aug 28, 2018 at 18:24 answer added Sᴀᴍ Onᴇᴌᴀ timeline score: 1
Aug 28, 2018 at 18:18 history edited user125391 CC BY-SA 4.0
added 58 characters in body
Aug 28, 2018 at 18:18 comment added user125391 The combination is not inefficient --- using only css in this case would be inefficient as I don't have comfortable control over the markup. In my case above only the JavaScript should be reviewed.
Aug 28, 2018 at 15:55 comment added insertusernamehere "advised me to take a pure CSS approach but I create my markup with a WordPress page builder and it feels to me inefficient" Why is it inefficient to use a combination of CSS and JavaScript? Is the markup and the CSS fixed or can anything be changed? Should only the JavaScript be reviewed?
Aug 28, 2018 at 14:55 history edited user125391 CC BY-SA 4.0
deleted 262 characters in body
S Aug 28, 2018 at 5:43 history bounty started CommunityBot
S Aug 28, 2018 at 5:43 history notice added user125391 Draw attention
Aug 23, 2018 at 17:33 history edited user125391 CC BY-SA 4.0
deleted 55 characters in body
Aug 23, 2018 at 16:50 history edited user125391 CC BY-SA 4.0
After the organizational changes I've made I no longer think it's "very potentially confusing".
Aug 23, 2018 at 16:34 history edited user125391 CC BY-SA 4.0
added 36 characters in body
Aug 23, 2018 at 14:44 history edited user125391 CC BY-SA 4.0
deleted 54 characters in body
Aug 23, 2018 at 14:38 history edited user125391 CC BY-SA 4.0
deleted 54 characters in body
Aug 23, 2018 at 14:08 history edited user125391 CC BY-SA 4.0
added 31 characters in body
Aug 23, 2018 at 13:38 history edited user125391 CC BY-SA 4.0
deleted 87 characters in body
Aug 23, 2018 at 13:21 history edited user125391 CC BY-SA 4.0
deleted 27 characters in body
Aug 23, 2018 at 12:47 history edited user125391 CC BY-SA 4.0
deleted 65 characters in body; edited title
Aug 23, 2018 at 12:20 history asked user125391 CC BY-SA 4.0