Return to Question

public static void main(String[] args) {

    ultraFizzBuzz((Integer arg) -> {
        String retVal = "";
        if(arg % 3 == 0) { retVal += "fizz"; }
        if(arg % 5 == 0) { retVal += "buzz"; }
        return retVal;
    });
}

public static void ultraFizzBuzz(modConditions<Integer> tester) {
    
    for(int i = 1; i < 100; i++) {
        String result = tester.test(i);
        if(result != "")
            System.out.println(result);
        else
            System.out.println(i);
    }
}

Am I overcomplicating things? Would this be considered bad programming practice?

EDIT:

Based on suggestions, here is revised code:

static List<Function<Integer, String>> fizzBuzzList = Arrays.asList(
    x -> x % 3 == 0 ? "fizz" : "",
    x -> x % 5 == 0 ? "buzz" : "",
    x -> x % 7 == 0 ? "pop"  : ""
);

public static void main(String[] args) {
    
    fizzBuzz(fizzBuzzList);
}

public static void fizzBuzz(List<Function<Integer, String>> tester) {
    
    for(int i = 1; i <= 100; i++) {
        boolean hasPrinted = false; // will be true if any functions in tester return non-empty string
        
        for(Function<Integer, String> f : tester) {
            String result = f.apply(i);
            
            if(!result.isEmpty()) {
                System.out.print(f.apply(i));
                hasPrinted = true;
            }
        }
        
        if(!hasPrinted) {
            System.out.print(i);
        }
        
        System.out.println();
    }
}

More logic is now based inside of the actual function

public static void main(String[] args) {

    ultraFizzBuzz((Integer arg) -> {
        String retVal = "";
        if(arg % 3 == 0) { retVal += "fizz"; }
        if(arg % 5 == 0) { retVal += "buzz"; }
        return retVal;
    });
}

public static void ultraFizzBuzz(modConditions<Integer> tester) {
    
    for(int i = 1; i < 100; i++) {
        String result = tester.test(i);
        if(result != "")
            System.out.println(tester.test(i));
        else
            System.out.println(i);
    }
}

Am I overcomplicating things? Would this be considered bad programming practice?

public static void main(String[] args) {

    ultraFizzBuzz((Integer arg) -> {
        String retVal = "";
        if(arg % 3 == 0) { retVal += "fizz"; }
        if(arg % 5 == 0) { retVal += "buzz"; }
        return retVal;
    });
}

public static void ultraFizzBuzz(modConditions<Integer> tester) {
    
    for(int i = 1; i < 100; i++) {
        String result = tester.test(i);
        if(result != "")
            System.out.println(tester.test(i));
        else
            System.out.println(i);
    }
}

public static void main(String[] args) {

    ultraFizzBuzz((Integer arg) -> {
        String retVal = "";
        if(arg % 3 == 0) { retVal += "fizz"; }
        if(arg % 5 == 0) { retVal += "buzz"; }
        return retVal;
    });
}

public static void ultraFizzBuzz(modConditions<Integer> tester) {
    
    for(int i = 1; i < 100; i++) {
        String result = tester.test(i);
        if(result != "")
            System.out.println(result);
        else
            System.out.println(i);
    }
}

EDIT:

Based on suggestions, here is revised code:

static List<Function<Integer, String>> fizzBuzzList = Arrays.asList(
    x -> x % 3 == 0 ? "fizz" : "",
    x -> x % 5 == 0 ? "buzz" : "",
    x -> x % 7 == 0 ? "pop"  : ""
);

public static void main(String[] args) {
    
    fizzBuzz(fizzBuzzList);
}

public static void fizzBuzz(List<Function<Integer, String>> tester) {
    
    for(int i = 1; i <= 100; i++) {
        boolean hasPrinted = false; // will be true if any functions in tester return non-empty string
        
        for(Function<Integer, String> f : tester) {
            String result = f.apply(i);
            
            if(!result.isEmpty()) {
                System.out.print(f.apply(i));
                hasPrinted = true;
            }
        }
        
        if(!hasPrinted) {
            System.out.print(i);
        }
        
        System.out.println();
    }
}

More logic is now based inside of the actual function