Skip to main content
Code Review

Return to Answer

deleted 15 characters in body
Source Link
Deduplicator
Deduplicator
  • 19.9k
  • 1
  • 32
  • 65

  1. Avoid owning raw pointers. Even without exceptions, they are prone to leak.
    Use a sensible std::unique_ptrstd::unique_ptr, std::anystd::any or std::variantstd::variant. The latter even avoid extra dynamic allocations, though at the cost of potentially wasting a small amount of memory.

  2. Are you sure there's always at least one person?

  1. Avoid owning raw pointers. Even without exceptions, they are prone to leak.
    Use a sensible std::unique_ptr, std::any or std::variant. The latter even avoid extra dynamic allocations, though at the cost of potentially wasting a small amount of memory.

  2. Are you sure there's always at least one person?

  1. Avoid owning raw pointers. Even without exceptions, they are prone to leak.
    Use a sensible std::unique_ptr, std::any or std::variant. The latter even avoid extra dynamic allocations, though at the cost of potentially wasting a small amount of memory.

  2. Are you sure there's always at least one person?

Source Link
Deduplicator
Deduplicator
  • 19.9k
  • 1
  • 32
  • 65

  1. Avoid owning raw pointers. Even without exceptions, they are prone to leak.
    Use a sensible std::unique_ptr, std::any or std::variant. The latter even avoid extra dynamic allocations, though at the cost of potentially wasting a small amount of memory.

  2. Are you sure there's always at least one person?