Timeline for Node.js module using Promises (client for KeePassHttp)
Current License: CC BY-SA 3.0
3 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Mar 14, 2017 at 0:12 | comment | added | michoel |
You have too few comments, and the code could definitely use some more. Can you give an example of where you think the code would benefit from more comments?
|
|
| Mar 14, 2017 at 0:09 | comment | added | michoel |
But that would break the code, because id is declared all the way on top, and you use it as a global variable (check function verify). That is not good practice. - are you sure about that? I was under the understanding that in node.js variables are scoped to the module, and is the correct way of having a variable available to the entire module (but not global).
|
|
| Mar 10, 2017 at 12:35 | history | answered | konijn | CC BY-SA 3.0 |