Revisions to Which way of writing a conditional test is the most readable?

deleted 3 characters in body

Source Link

edited Jan 3, 2017 at 17:31

35.2k
13
134
238

I have three conditions like the following:

1.

if (IsAllTriggersRequired && meterFlag && workFlag && timeFlag)
{
    result.Add(new TodayTaskTest { Code = item1.Code, Id = item1.Id, Title = item1.Title });
}
else if (!IsAllTriggersRequired && (meterFlag || workFlag || timeFlag))
{
    result.Add(new TodayTaskTest { Code = item1.Code, Id = item1.Id, Title = item1.Title });
}

2.

if ((IsAllTriggersRequired && meterFlag && workFlag && timeFlag) ||(!IsAllTriggersRequired && (meterFlag || workFlag || timeFlag)))
{
    result.Add(new TodayTaskTest { Code = item1.Code, Id = item1.Id, Title = item1.Title });
}

3.

bool isAdd = false;

if (IsAllTriggersRequired && meterFlag && workFlag && timeFlag)
    isAdd = true;
else if (!IsAllTriggersRequired && (meterFlag || workFlag || timeFlag))
    isAdd = true;

if (isAdd)
    result.Add(new TodayTaskTest { Code = item1.Code, Id = item1.Id, Title = item1.Title });

In the second one, can I avoid repeating the same code?

I have three conditions like the following:

1.

if (IsAllTriggersRequired && meterFlag && workFlag && timeFlag)
{
    result.Add(new TodayTaskTest { Code = item1.Code, Id = item1.Id, Title = item1.Title });
}
else if (!IsAllTriggersRequired && (meterFlag || workFlag || timeFlag))
{
    result.Add(new TodayTaskTest { Code = item1.Code, Id = item1.Id, Title = item1.Title });
}

2.

if ((IsAllTriggersRequired && meterFlag && workFlag && timeFlag) ||(!IsAllTriggersRequired && (meterFlag || workFlag || timeFlag)))
{
    result.Add(new TodayTaskTest { Code = item1.Code, Id = item1.Id, Title = item1.Title });
}

3.

bool isAdd = false;

if (IsAllTriggersRequired && meterFlag && workFlag && timeFlag)
    isAdd = true;
else if (!IsAllTriggersRequired && (meterFlag || workFlag || timeFlag))
    isAdd = true;

if (isAdd)
    result.Add(new TodayTaskTest { Code = item1.Code, Id = item1.Id, Title = item1.Title });

In the second one, can I avoid repeating the same code?

I have three conditions like the following:

if (IsAllTriggersRequired && meterFlag && workFlag && timeFlag)
{
    result.Add(new TodayTaskTest { Code = item1.Code, Id = item1.Id, Title = item1.Title });
}
else if (!IsAllTriggersRequired && (meterFlag || workFlag || timeFlag))
{
    result.Add(new TodayTaskTest { Code = item1.Code, Id = item1.Id, Title = item1.Title });
}

if ((IsAllTriggersRequired && meterFlag && workFlag && timeFlag) ||(!IsAllTriggersRequired && (meterFlag || workFlag || timeFlag)))
{
    result.Add(new TodayTaskTest { Code = item1.Code, Id = item1.Id, Title = item1.Title });
}

bool isAdd = false;

if (IsAllTriggersRequired && meterFlag && workFlag && timeFlag)
    isAdd = true;
else if (!IsAllTriggersRequired && (meterFlag || workFlag || timeFlag))
    isAdd = true;

if (isAdd)
    result.Add(new TodayTaskTest { Code = item1.Code, Id = item1.Id, Title = item1.Title });

In the second one, can I avoid repeating the same code?

edited tags

Link

edited Jan 3, 2017 at 14:48

t3chb0t

44.7k
9
84
191

c# comparative-review

fixed typo in code

Source Link

edited Jan 3, 2017 at 14:46

JanDotNet

8.6k
2
22
48

I have three conditions like the following:

1.

if (IsAllTriggersRequired && meterFlag && workFlag && timeFalgtimeFlag)
{
    result.Add(new TodayTaskTest { Code = item1.Code, Id = item1.Id, Title = item1.Title });
}
else if (!IsAllTriggersRequired && (meterFlag || workFlag || timeFalgtimeFlag))
{
    result.Add(new TodayTaskTest { Code = item1.Code, Id = item1.Id, Title = item1.Title });
}

2.

if ((IsAllTriggersRequired && meterFlag && workFlag && timeFalgtimeFlag) ||(!IsAllTriggersRequired && (meterFlag || workFlag || timeFalgtimeFlag)))
{
    result.Add(new TodayTaskTest { Code = item1.Code, Id = item1.Id, Title = item1.Title });
}

3.

bool isAdd = false;

if (IsAllTriggersRequired && meterFlag && workFlag && timeFalgtimeFlag)
    isAdd = true;
else if (!IsAllTriggersRequired && (meterFlag || workFlag || timeFalgtimeFlag))
    isAdd = true;

if (isAdd)
    result.Add(new TodayTaskTest { Code = item1.Code, Id = item1.Id, Title = item1.Title });

In the second one, can I avoid repeating the same code?

I have three conditions like the following:

1.

if (IsAllTriggersRequired && meterFlag && workFlag && timeFalg)
{
    result.Add(new TodayTaskTest { Code = item1.Code, Id = item1.Id, Title = item1.Title });
}
else if (!IsAllTriggersRequired && (meterFlag || workFlag || timeFalg))
{
    result.Add(new TodayTaskTest { Code = item1.Code, Id = item1.Id, Title = item1.Title });
}

2.

if ((IsAllTriggersRequired && meterFlag && workFlag && timeFalg) ||(!IsAllTriggersRequired && (meterFlag || workFlag || timeFalg)))
{
    result.Add(new TodayTaskTest { Code = item1.Code, Id = item1.Id, Title = item1.Title });
}

3.

bool isAdd = false;

if (IsAllTriggersRequired && meterFlag && workFlag && timeFalg)
    isAdd = true;
else if (!IsAllTriggersRequired && (meterFlag || workFlag || timeFalg))
    isAdd = true;

if (isAdd)
    result.Add(new TodayTaskTest { Code = item1.Code, Id = item1.Id, Title = item1.Title });

In the second one, can I avoid repeating the same code?

I have three conditions like the following:

1.

if (IsAllTriggersRequired && meterFlag && workFlag && timeFlag)
{
    result.Add(new TodayTaskTest { Code = item1.Code, Id = item1.Id, Title = item1.Title });
}
else if (!IsAllTriggersRequired && (meterFlag || workFlag || timeFlag))
{
    result.Add(new TodayTaskTest { Code = item1.Code, Id = item1.Id, Title = item1.Title });
}

2.

if ((IsAllTriggersRequired && meterFlag && workFlag && timeFlag) ||(!IsAllTriggersRequired && (meterFlag || workFlag || timeFlag)))
{
    result.Add(new TodayTaskTest { Code = item1.Code, Id = item1.Id, Title = item1.Title });
}

3.

bool isAdd = false;

if (IsAllTriggersRequired && meterFlag && workFlag && timeFlag)
    isAdd = true;
else if (!IsAllTriggersRequired && (meterFlag || workFlag || timeFlag))
    isAdd = true;

if (isAdd)
    result.Add(new TodayTaskTest { Code = item1.Code, Id = item1.Id, Title = item1.Title });

In the second one, can I avoid repeating the same code?

Improve title, code formatting, and grammar. I've fixed the code's indentation here because I *think* it is just unfamiliarity with the code-formatting toolbar button, rather than something that actually needs to be commented upon in a review.

Source Link

edit approved Jan 3, 2017 at 14:42

Cody Gray

4.6k
20
30

Loading

Source Link

asked Jan 3, 2017 at 13:18

osman Rahimi

147
7

Loading

Stack Exchange Network

Return to Question

1.

2.

3.

1.

2.

3.

1.

2.

3.

1.

2.

3.

1.

2.

3.