Revisions to Refactor to avoid cope repetition in loop with condition checking

Rollback to Revision 5

Source Link

edited Aug 19, 2016 at 13:16

51k
5
83
177

Update

Thanks for SQB's answer. I've been refactored my code into this (I also update the nil checking before insert an array element into groups array):

sample_serializer_selector =
  if own_collection
    lambda { |s| SampleSerializer::Level10.new(s, 10).serializable_hash }
  else
    lambda { |s| ElementPermissionProxy.new(current_user, s, user_ids).serialized }
  end

samples.each do |sample|
  sample_name = get_name(sample)
  serialized_sample = sample_serializer_selector.call(sample)
  groups[sample_name] = (groups[sample_name] || []).push(serialized_sample)
end

Much more better :)

Update

Thanks for SQB's answer. I've been refactored my code into this (I also update the nil checking before insert an array element into groups array):

sample_serializer_selector =
  if own_collection
    lambda { |s| SampleSerializer::Level10.new(s, 10).serializable_hash }
  else
    lambda { |s| ElementPermissionProxy.new(current_user, s, user_ids).serialized }
  end

samples.each do |sample|
  sample_name = get_name(sample)
  serialized_sample = sample_serializer_selector.call(sample)
  groups[sample_name] = (groups[sample_name] || []).push(serialized_sample)
end

Much more better :)

added 744 characters in body

Source Link

edited Aug 19, 2016 at 13:12

An Nguyen

151
5

Update

Thanks for SQB's answer. I've been refactored my code into this (I also update the nil checking before insert an array element into groups array):

sample_serializer_selector =
  if own_collection
    lambda { |s| SampleSerializer::Level10.new(s, 10).serializable_hash }
  else
    lambda { |s| ElementPermissionProxy.new(current_user, s, user_ids).serialized }
  end

samples.each do |sample|
  sample_name = get_name(sample)
  serialized_sample = sample_serializer_selector.call(sample)
  groups[sample_name] = (groups[sample_name] || []).push(serialized_sample)
end

Much more better :)

Update

Thanks for SQB's answer. I've been refactored my code into this (I also update the nil checking before insert an array element into groups array):

sample_serializer_selector =
  if own_collection
    lambda { |s| SampleSerializer::Level10.new(s, 10).serializable_hash }
  else
    lambda { |s| ElementPermissionProxy.new(current_user, s, user_ids).serialized }
  end

samples.each do |sample|
  sample_name = get_name(sample)
  serialized_sample = sample_serializer_selector.call(sample)
  groups[sample_name] = (groups[sample_name] || []).push(serialized_sample)
end

Much more better :)

edited tags

Link

edited Aug 19, 2016 at 11:50

An Nguyen

151
5

ruby ruby-on-rails

edited title

Link

edited Aug 19, 2016 at 10:44

An Nguyen

151
5

Loading

deleted 23 characters in body

Source Link

edited Aug 19, 2016 at 10:35

Jamal

35.2k
13
134
238

Loading

edited title

Link

edited Aug 19, 2016 at 10:29

An Nguyen

151
5

Loading

Source Link

asked Aug 19, 2016 at 10:14

An Nguyen

151
5

Loading

Stack Exchange Network

Return to Question

Update

Update

Update

Update