Timeline for Composing QGIS expression based on a QGIS layer tree
Current License: CC BY-SA 3.0
15 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Apr 13, 2017 at 12:40 | history | edited | CommunityBot |
replaced http://codereview.stackexchange.com/ with https://codereview.stackexchange.com/
|
|
| May 13, 2016 at 11:44 | history | rollback | Mast♦ |
Rollback to Revision 2
|
|
| S May 13, 2016 at 9:38 | history | suggested | Joseph | CC BY-SA 3.0 |
Edited code due to mistake on my part
|
| May 13, 2016 at 9:21 | comment | added | Joseph | Edited your final code to take into account a couple of things I didn't put into the original question =) | |
| May 13, 2016 at 9:14 | review | Suggested edits | |||
| S May 13, 2016 at 9:38 | |||||
| May 12, 2016 at 18:31 | history | edited | Peilonrayz♦ | CC BY-SA 3.0 |
Updated with new information, and code.
|
| May 12, 2016 at 15:11 | comment | added | Peilonrayz♦ | @Joseph "please don't feel obligated to improve it", it's too late for that now. It will be improved. | |
| May 12, 2016 at 15:09 | comment | added | Joseph | Yes, that is a pretty good technique! Your code works great the way it is so please don't feel obligated to improve it =) | |
| May 12, 2016 at 15:02 | comment | added | Peilonrayz♦ |
@Joseph I'll add the code when I get back from work, but basically it's what scottbb said in "6. Use delimiter.join() to join strings together" The use of ' OR '.join allows you to remove formulas and formula1 through formula4. Which should increase both performance and readability. (But you also would use ' + '.join ;P)
|
|
| May 12, 2016 at 14:54 | comment | added | Joseph |
Most welcome, I appreciate you keeping everything in the code! At the moment, it is just the final_formula I need but I'm curious as to what you mean by making the "algorithm much better"? :)
|
|
| May 12, 2016 at 14:45 | comment | added | Peilonrayz♦ |
@Joseph Thank you, :) Just wondering, do you only want final_formula? Cause you can make the algorithm much better, and from your examples that you added you seem to only use it... (I didn't know, so I tried to keep everything)
|
|
| May 12, 2016 at 14:30 | vote | accept | Joseph | ||
| May 12, 2016 at 14:30 | comment | added | Joseph | Wish I could accept both answers but will accept this one as you answered first with very readable code =) | |
| May 12, 2016 at 9:35 | comment | added | Joseph | Wow, that makes quite a difference! Thank you very much for this, I will implement this and see how it goes :) | |
| May 10, 2016 at 16:30 | history | answered | Peilonrayz♦ | CC BY-SA 3.0 |