Timeline for Implementing Search method For a Class
Current License: CC BY-SA 3.0
6 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Oct 15, 2015 at 15:43 | comment | added | user2023861 |
I may be wrong, but I think this is mostly SOLID. The only reason I can see to change the code would be to change which fields you're searching, so that's the S. I don't see any inheritance, so the O doesn't apply. Same thing for the L. I don't see any monster interfaces, so the I doesn't apply. The one problem I see is that you new up a GenericRepository<Rows>. This violates the D. That dependency should be injected.
|
|
| Oct 15, 2015 at 15:17 | answer | added | t3chb0t | timeline score: 2 | |
| Oct 15, 2015 at 7:23 | history | edited | Akbari | CC BY-SA 3.0 |
deleted 138 characters in body
|
| Oct 15, 2015 at 6:49 | answer | added | Heslacher | timeline score: 2 | |
| Oct 15, 2015 at 6:30 | history | edited | Akbari | CC BY-SA 3.0 |
added 351 characters in body
|
| Oct 15, 2015 at 6:26 | history | asked | Akbari | CC BY-SA 3.0 |